[tsp-client] Update output-dir processing#13355
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the output-dir option processing to improve code clarity by explicitly handling the undefined case. The default value is changed from "." to undefined, and the resolveOutputDir function is updated to check for undefined explicitly before calling resolvePath.
Key Changes:
- Changed the default value of the
output-diroption from"."toundefined - Added explicit conditional logic to handle undefined
output-dirby directly usingprocess.cwd()
|
Hi @catalinaperalta. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
github-actions
bot
added
the
no-recent-activity
|
Hi @catalinaperalta. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
Fix output-dir processing by defaulting the value to undefined unless otherwise specified. There should be no behavioral change due to this update, due to the change to defaulting to undefined, if
--output-dirisn't passed tsp-client will still resolve it to the cwd(), otherwise the value will be resolved in relation to the cwd() same as before.